Implement decision state machine #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shijiesheng
reviewed
Aug 14, 2025
shijiesheng
reviewed
Aug 19, 2025
…ting for state transition
natemort
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implemented decision state machine system for Cadence Python client including:
DecisionStateMachineclass for workflow decision lifecycle trackingActivityDecisionMachinefor activity task scheduling, execution, and cancellationTimerDecisionMachinefor timer operationsChildWorkflowDecisionMachinefor child workflow lifecycle managementDecisionManagerfor aggregating state machines and coordinating decisionsAlso try to use proto types directly and avoid any mapping
(heavily relied on Go client state machine: https://github.com/cadence-workflow/cadence-go-client/blob/master/internal/internal_decision_state_machine.go)
Why?
Workflows need to track what decisions they've made and what state they're in. This state machine ensures decisions are made correctly, in the right order, and handles properly. It's essential for deterministic workflow execution.
How did you test it?
Local unit tests
uv testPotential risks
Release notes
Documentation Changes